DigitaleBibliothek / Frontend / 418fe5c5cef

Commits

Tim Donohue authored and GitHub committed 418fe5c5cef Merge 23 Oct 2020

Merge pull request #881 from jonas-atmire/w2p-72326-Back-link-on-bitstream-edit-page

Back link on bitstream edit page

src/app/+bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts

Modified

-1
+import { EditBitstreamPageComponent } from './edit-bitstream-page.component';
-2
+import { async, ComponentFixture, TestBed } from '@angular/core/testing';
-3
+import { TranslateModule } from '@ngx-translate/core';
-4
+import { RouterTestingModule } from '@angular/router/testing';
-5
+import { RemoteData } from '../../core/data/remote-data';
-6
+import { of as observableOf } from 'rxjs/internal/observable/of';
--
+import { ActivatedRoute } from '@angular/router';
-+
+import {ActivatedRoute, Router} from '@angular/router';
-8
+import { DynamicFormControlModel, DynamicFormService } from '@ng-dynamic-forms/core';
-9
+import { NotificationsService } from '../../shared/notifications/notifications.service';
-10
+import { BitstreamDataService } from '../../core/data/bitstream-data.service';
-11
+import { ChangeDetectorRef, NO_ERRORS_SCHEMA } from '@angular/core';
-12
+import { BitstreamFormatDataService } from '../../core/data/bitstream-format-data.service';
-13
+import { Bitstream } from '../../core/shared/bitstream.model';
-14
+import { NotificationType } from '../../shared/notifications/models/notification-type';
-15
+import { INotification, Notification } from '../../shared/notifications/models/notification.model';
-16
+import { BitstreamFormat } from '../../core/shared/bitstream-format.model';
-17
+import { BitstreamFormatSupportLevel } from '../../core/shared/bitstream-format-support-level';
-18
+import { hasValue } from '../../shared/empty.util';
-19
+import { FormControl, FormGroup } from '@angular/forms';
-20
+import { PaginatedList } from '../../core/data/paginated-list';
-21
+import { PageInfo } from '../../core/shared/page-info.model';
-22
+import { FileSizePipe } from '../../shared/utils/file-size-pipe';
-23
+import { RestResponse } from '../../core/cache/response.models';
-24
+import { VarDirective } from '../../shared/utils/var.directive';
-+
+import {
-+
+  createSuccessfulRemoteDataObject$
-+
+} from '../../shared/remote-data.utils';
-+
+import {RouterStub} from '../../shared/testing/router.stub';
-+
+import { getItemEditRoute } from '../../+item-page/item-page-routing-paths';
-30
-31
+const infoNotification: INotification = new Notification('id', NotificationType.Info, 'info');
-32
+const warningNotification: INotification = new Notification('id', NotificationType.Warning, 'warning');
-33
+const successNotification: INotification = new Notification('id', NotificationType.Success, 'success');
-34
-35
+let notificationsService: NotificationsService;
-36
+let formService: DynamicFormService;
-37
+let bitstreamService: BitstreamDataService;
-38
+let bitstreamFormatService: BitstreamFormatDataService;
-39
+let bitstream: Bitstream;
-40
+let selectedFormat: BitstreamFormat;
-41
+let allFormats: BitstreamFormat[];
-+
+let router: Router;
-+
+let routerStub;
-44
-45
+describe('EditBitstreamPageComponent', () => {
-46
+  let comp: EditBitstreamPageComponent;
-47
+  let fixture: ComponentFixture<EditBitstreamPageComponent>;
-48
-49
+  beforeEach(async(() => {
-50
+    allFormats = [
-51
+      Object.assign({
-52
+        id: '1',
-53
+        shortDescription: 'Unknown',
-105
+        ],
-106
+        'dc.title': [
-107
+          {
-108
+            value: 'Bitstream title'
-109
+          }
-110
+        ]
-111
+      },
-112
+      format: observableOf(new RemoteData(false, false, true, null, selectedFormat)),
-113
+      _links: {
-114
+        self: 'bitstream-selflink'
--
+      }
-+
+      },
-+
+      bundle: createSuccessfulRemoteDataObject$({
-+
+        item: createSuccessfulRemoteDataObject$({
-+
+          uuid: 'some-uuid'
-+
+        })
-+
+      })
-121
+    });
-122
+    bitstreamService = jasmine.createSpyObj('bitstreamService', {
-123
+      findById: observableOf(new RemoteData(false, false, true, null, bitstream)),
-124
+      update: observableOf(new RemoteData(false, false, true, null, bitstream)),
-125
+      updateFormat: observableOf(new RestResponse(true, 200, 'OK')),
-126
+      commitUpdates: {},
-127
+      patch: {}
-128
+    });
-129
+    bitstreamFormatService = jasmine.createSpyObj('bitstreamFormatService', {
-130
+      findAll: observableOf(new RemoteData(false, false, true, null, new PaginatedList(new PageInfo(), allFormats)))
-131
+    });
-132
-+
+    const itemPageUrl = `fake-url/some-uuid`;
-+
+    routerStub = Object.assign(new RouterStub(), {
-+
+      url: `${itemPageUrl}`
-+
+    });
-137
+    TestBed.configureTestingModule({
-138
+      imports: [TranslateModule.forRoot(), RouterTestingModule],
-139
+      declarations: [EditBitstreamPageComponent, FileSizePipe, VarDirective],
-140
+      providers: [
-141
+        { provide: NotificationsService, useValue: notificationsService },
-142
+        { provide: DynamicFormService, useValue: formService },
-143
+        { provide: ActivatedRoute, useValue: { data: observableOf({ bitstream: new RemoteData(false, false, true, null, bitstream) }), snapshot: { queryParams: {} } } },
-144
+        { provide: BitstreamDataService, useValue: bitstreamService },
-145
+        { provide: BitstreamFormatDataService, useValue: bitstreamFormatService },
-+
+        { provide: Router, useValue: routerStub },
-147
+        ChangeDetectorRef
-148
+      ],
-149
+      schemas: [NO_ERRORS_SCHEMA]
-150
+    }).compileComponents();
-151
-152
+  }));
-153
-154
+  beforeEach(() => {
-155
+    fixture = TestBed.createComponent(EditBitstreamPageComponent);
-156
+    comp = fixture.componentInstance;
-157
+    fixture.detectChanges();
-+
+    router = (comp as any).router;
-159
+  });
-160
-161
+  describe('on startup', () => {
-162
+    let rawForm;
-163
-164
+    beforeEach(() => {
-165
+      rawForm = comp.formGroup.getRawValue();
-166
+    });
-167
-168
+    it('should fill in the bitstream\'s title', () => {
-224
-225
+      it('should call updateFormat', () => {
-226
+        expect(bitstreamService.updateFormat).toHaveBeenCalled();
-227
+      });
-228
-229
+      it('should commit the updates', () => {
-230
+        expect(bitstreamService.commitUpdates).toHaveBeenCalled();
-231
+      });
-232
+    });
-233
+  });
-+
+  describe('when the cancel button is clicked', () => {
-+
+    it('should call navigateToItemEditBitstreams method', () => {
-+
+      spyOn(comp, 'navigateToItemEditBitstreams');
-+
+      comp.onCancel();
-+
+      expect(comp.navigateToItemEditBitstreams).toHaveBeenCalled();
-+
+    });
-+
+  });
-+
+  describe('when navigateToItemEditBitstreams is called, and the component has an itemId', () => {
-+
+    it('should redirect to the item edit page on the bitstreams tab with the itemId from the component', () => {
-+
+      comp.itemId = 'some-uuid1'
-+
+      comp.navigateToItemEditBitstreams();
-+
+      expect(routerStub.navigate).toHaveBeenCalledWith([getItemEditRoute('some-uuid1'), 'bitstreams']);
-+
+    });
-+
+  });
-+
+  describe('when navigateToItemEditBitstreams is called, and the component does not have an itemId', () => {
-+
+    it('should redirect to the item edit page on the bitstreams tab with the itemId from the bundle links ', () => {
-+
+      comp.itemId = undefined;
-+
+      comp.navigateToItemEditBitstreams();
-+
+      expect(routerStub.navigate).toHaveBeenCalledWith([getItemEditRoute('some-uuid'), 'bitstreams']);
-+
+    });
-+
+  });
-255
+});

Frontend

Commits

Jira Issues

Add shortcut