DigitaleBibliothek / Frontend / 381254a16e5

Commits

Michael Spalti authored and github-actions[bot] committed 381254a16e5 17 Nov 2023

File edit component updated to work for forms without access conditions.

Fixed unit test

Fixed accidental reformatting

(cherry picked from commit 6fff475a5a0a8a2a234b114307e3df897400da60)

src/app/submission/sections/upload/file/edit/section-upload-file-edit.component.spec.ts

Modified

-73
+  const sectionId = 'upload';
-74
+  const collectionId = mockSubmissionCollectionId;
-75
+  const availableAccessConditionOptions = mockUploadConfigResponse.accessConditionOptions;
-76
+  const collectionPolicyType = POLICY_DEFAULT_WITH_LIST;
-77
+  const configMetadataForm: any = mockUploadConfigResponseMetadata;
-78
+  const fileIndex = '0';
-79
+  const fileId = '123456-test-upload';
-80
+  const fileData: any = mockUploadFiles[0];
-81
+  const pathCombiner = new JsonPatchOperationPathCombiner('sections', sectionId, 'files', fileIndex);
-82
-+
+  let noAccessConditionsMock = Object.assign({}, mockFileFormData);
-+
+  delete noAccessConditionsMock.accessConditions;
-+
-86
+  beforeEach(waitForAsync(() => {
-87
+    TestBed.configureTestingModule({
-88
+      imports: [
-89
+        BrowserModule,
-90
+        CommonModule,
-91
+        FormsModule,
-92
+        ReactiveFormsModule,
-93
+        TranslateModule.forRoot()
-94
+      ],
-95
+      declarations: [
-295
+      expect(operationsBuilder.add).toHaveBeenCalledWith(
-296
+        pathCombiner.getPath(path),
-297
+        accessConditionsToSave,
-298
+        true
-299
+      );
-300
-301
+      expect(uploadService.updateFileData).toHaveBeenCalledWith(submissionId, sectionId, mockUploadFiles[0].uuid, mockUploadFiles[0]);
-302
-303
+    }));
-304
-+
+    it('should update Bitstream data properly when access options are omitted', fakeAsync(() => {
-+
+      compAsAny.formRef = {formGroup: null};
-+
+      compAsAny.fileData = fileData;
-+
+      compAsAny.pathCombiner = pathCombiner;
-+
+      formService.validateAllFormFields.and.callFake(() => null);
-+
+      formService.isValid.and.returnValue(of(true));
-+
+      formService.getFormData.and.returnValue(of(noAccessConditionsMock));
-+
+      const response = [
-+
+        Object.assign(mockSubmissionObject, {
-+
+          sections: {
-+
+            upload: {
-+
+              files: mockUploadFiles
-+
+            }
-+
+          }
-+
+        })
-+
+      ];
-+
+      operationsService.jsonPatchByResourceID.and.returnValue(of(response));
-+
+      comp.saveBitstreamData();
-+
+      tick();
-+
+      expect(uploadService.updateFileData).toHaveBeenCalled();
-+
+    }));
-+
-327
+    it('should not save Bitstream File data properly when form is not valid', fakeAsync(() => {
-328
+      compAsAny.formRef = {formGroup: null};
-329
+      compAsAny.pathCombiner = pathCombiner;
-330
+      formService.validateAllFormFields.and.callFake(() => null);
-331
+      formService.isValid.and.returnValue(of(false));
-332
+      comp.saveBitstreamData();
-333
+      tick();
-334
-335
+      expect(uploadService.updateFileData).not.toHaveBeenCalled();
-336

Frontend

Commits

Jira Issues

Add shortcut