DigitaleBibliothek / Frontend / 47302acf66b

Commits

Tim Donohue authored and GitHub committed 47302acf66b Merge 26 Jul 2021

Merge pull request #1282 from tdonohue/test_ssr_working

SEO + SSR fixes: Fix <meta> tag syntax and add a basic test that SSR is working

.github/workflows/build.yml

Modified

-110
+            timeout: 30000
-111
-112
+      - name: Get DSpace REST Backend info/properties
-113
+        run: curl http://localhost:8080/server/api
-114
-115
+      - name: Run e2e tests (integration tests)
-116
+        run: |
-117
+          chromedriver --url-base='/wd/hub' --port=4444 &
-118
+          yarn run e2e:ci
-119
-+
+      # Start up the app with SSR enabled (run in background)
-+
+      - name: Start app in SSR (server-side rendering) mode
-+
+        run: |
-+
+          nohup yarn run serve:ssr &
-+
+          printf 'Waiting for app to start'
-+
+          until curl --output /dev/null --silent --head --fail http://localhost:4000/home; do
-+
+            printf '.'
-+
+            sleep 2
-+
+          done
-+
+          echo "App started successfully."
-+
-+
+      # Get homepage and verify that the <meta name="title"> tag includes "DSpace".
-+
+      # If it does, then SSR is working, as this tag is created by our MetadataService.
-+
+      # This step also prints entire HTML of homepage for easier debugging if grep fails.
-+
+      - name: Verify SSR (server-side rendering)
-+
+        run: |
-+
+          result=$(wget -O- -q http://localhost:4000/home)
-+
+          echo "$result"
-+
+          echo "$result" | grep -oE "<meta name=\"title\" [^>]*>" | grep DSpace
-+
-+
+      - name: Stop running app
-+
+        run: kill -9 $(lsof -t -i:4000)
-+
-143
+      - name: Shutdown Docker containers
-144
+        run: docker-compose -f ./docker/docker-compose-ci.yml down

Frontend

Commits

Jira Issues

Add shortcut