DigitaleBibliothek / Frontend / 499463f47e5

Commits

Tim Donohue authored and GitHub committed 499463f47e5 Merge 07 Sep 2023

Merge pull request #2349 from alexandrevryghem/fix-setStaleByHrefSubtring-not-emitting-after-all-requests-were-stale_contribute-main

Fix `setStaleByHrefSubstring` not emitting true when all requests are stale

src/app/core/data/request.service.spec.ts

Modified

-1
+import { Store, StoreModule } from '@ngrx/store';
-2
+import { cold, getTestScheduler } from 'jasmine-marbles';
--
+import { EMPTY, of as observableOf } from 'rxjs';
-+
+import { EMPTY, Observable, of as observableOf } from 'rxjs';
-4
+import { TestScheduler } from 'rxjs/testing';
-5
-6
+import { getMockObjectCacheService } from '../../shared/mocks/object-cache.service.mock';
-7
+import { defaultUUID, getMockUUIDService } from '../../shared/mocks/uuid.service.mock';
-8
+import { ObjectCacheService } from '../cache/object-cache.service';
-9
+import { coreReducers} from '../core.reducers';
-10
+import { UUIDService } from '../shared/uuid.service';
-11
+import { RequestConfigureAction, RequestExecuteAction, RequestStaleAction } from './request.actions';
-12
+import {
-13
+  DeleteRequest,
-631
+        a: { state: RequestEntryState.ResponsePending },
-632
+        b: { state: RequestEntryState.Success },
-633
+        c: { state: RequestEntryState.SuccessStale },
-634
+        d: { state: RequestEntryState.Error },
-635
+      }));
-636
-637
+      const done$ = service.setStaleByUUID('something');
-638
+      expect(done$).toBeObservable(cold('-----(t|)', { t: true }));
-639
+    }));
-640
+  });
-+
-+
+  describe('setStaleByHrefSubstring', () => {
-+
+    let dispatchSpy: jasmine.Spy;
-+
+    let getByUUIDSpy: jasmine.Spy;
-+
-+
+    beforeEach(() => {
-+
+      dispatchSpy = spyOn(store, 'dispatch');
-+
+      getByUUIDSpy = spyOn(service, 'getByUUID').and.callThrough();
-+
+    });
-+
-+
+    describe('with an empty/no matching requests in the state', () => {
-+
+      it('should return true', () => {
-+
+        const done$: Observable<boolean> = service.setStaleByHrefSubstring('https://rest.api/endpoint/selfLink');
-+
+        expect(done$).toBeObservable(cold('(a|)', { a: true }));
-+
+      });
-+
+    });
-+
-+
+    describe('with a matching request in the state', () => {
-+
+      beforeEach(() => {
-+
+        const state = Object.assign({}, initialState, {
-+
+          core: Object.assign({}, initialState.core, {
-+
+            'index': {
-+
+              'get-request/href-to-uuid': {
-+
+                'https://rest.api/endpoint/selfLink': '5f2a0d2a-effa-4d54-bd54-5663b960f9eb'
-+
+              }
-+
+            }
-+
+          })
-+
+        });
-+
+        mockStore.setState(state);
-+
+      });
-+
-+
+      it('should return an Observable that emits true as soon as the request is stale', () => {
-+
+        dispatchSpy.and.callFake(() => { /* empty */ });   // don't actually set as stale
-+
+        getByUUIDSpy.and.returnValue(cold('a-b--c--d-', {  // but fake the state in the cache
-+
+          a: { state: RequestEntryState.ResponsePending },
-+
+          b: { state: RequestEntryState.Success },
-+
+          c: { state: RequestEntryState.SuccessStale },
-+
+          d: { state: RequestEntryState.Error },
-+
+        }));
-+
+        const done$: Observable<boolean> = service.setStaleByHrefSubstring('https://rest.api/endpoint/selfLink');
-+
+        expect(done$).toBeObservable(cold('-----(a|)', { a: true }));
-+
+      });
-+
+    });
-+
+  });
-685
+});

Frontend

Commits

Jira Issues

Add shortcut