DigitaleBibliothek / Frontend / 9117ac005f5

Commits

Tim Donohue authored 9117ac005f5 09 Nov 2023

Address feedback.

Run empty search on init. Reorder sections to list current members before add members (for both eperson and groups)

src/app/access-control/group-registry/group-form/members-list/members-list.component.html

Modified

-1
+<ng-container>
-2
+  <h3 class="border-bottom pb-2">{{messagePrefix + '.head' | translate}}</h3>
-3
-+
+  <h4>{{messagePrefix + '.headMembers' | translate}}</h4>
-+
-+
+  <ds-pagination *ngIf="(ePeopleMembersOfGroup | async)?.totalElements > 0"
-+
+                 [paginationOptions]="config"
-+
+                 [pageInfoState]="(ePeopleMembersOfGroup | async)"
-+
+                 [collectionSize]="(ePeopleMembersOfGroup | async)?.totalElements"
-+
+                 [hideGear]="true"
-+
+                 [hidePagerWhenSinglePage]="true">
-+
-+
+    <div class="table-responsive">
-+
+      <table id="ePeopleMembersOfGroup" class="table table-striped table-hover table-bordered">
-+
+        <thead>
-+
+        <tr>
-+
+          <th scope="col" class="align-middle">{{messagePrefix + '.table.id' | translate}}</th>
-+
+          <th scope="col" class="align-middle">{{messagePrefix + '.table.name' | translate}}</th>
-+
+          <th scope="col" class="align-middle">{{messagePrefix + '.table.identity' | translate}}</th>
-+
+          <th class="align-middle">{{messagePrefix + '.table.edit' | translate}}</th>
-+
+        </tr>
-+
+        </thead>
-+
+        <tbody>
-+
+        <tr *ngFor="let eperson of (ePeopleMembersOfGroup | async)?.page">
-+
+          <td class="align-middle">{{eperson.id}}</td>
-+
+          <td class="align-middle">
-+
+            <a (click)="ePersonDataService.startEditingNewEPerson(eperson)"
-+
+               [routerLink]="[ePersonDataService.getEPeoplePageRouterLink()]">
-+
+              {{ dsoNameService.getName(eperson) }}
-+
+            </a>
-+
+          </td>
-+
+          <td class="align-middle">
-+
+            {{messagePrefix + '.table.email' | translate}}: {{ eperson.email ? eperson.email : '-' }}<br/>
-+
+            {{messagePrefix + '.table.netid' | translate}}: {{ eperson.netid ? eperson.netid : '-' }}
-+
+          </td>
-+
+          <td class="align-middle">
-+
+            <div class="btn-group edit-field">
-+
+              <button (click)="deleteMemberFromGroup(eperson)"
-+
+                      [disabled]="actionConfig.remove.disabled"
-+
+                      [ngClass]="['btn btn-sm', actionConfig.remove.css]"
-+
+                      title="{{messagePrefix + '.table.edit.buttons.remove' | translate: { name: dsoNameService.getName(eperson) } }}">
-+
+                <i [ngClass]="actionConfig.remove.icon"></i>
-+
+              </button>
-+
+            </div>
-+
+          </td>
-+
+        </tr>
-+
+        </tbody>
-+
+      </table>
-+
+    </div>
-+
-+
+  </ds-pagination>
-+
-+
+  <div *ngIf="(ePeopleMembersOfGroup | async) == undefined || (ePeopleMembersOfGroup | async)?.totalElements == 0" class="alert alert-info w-100 mb-2"
-+
+       role="alert">
-+
+    {{messagePrefix + '.no-members-yet' | translate}}
-+
+  </div>
-+
-58
+  <h4 id="search" class="border-bottom pb-2">
-59
+    <span
-60
+      *dsContextHelp="{
-61
+        content: 'admin.access-control.groups.form.tooltip.editGroup.addEpeople',
-62
+        id: 'edit-group-add-epeople',
-63
+        iconPlacement: 'right',
-64
+        tooltipPlacement: ['top', 'right', 'bottom']
-65
+      }"
-66
+    >
-67
+      {{messagePrefix + '.search.head' | translate}}
-131
+    </div>
-132
-133
+  </ds-pagination>
-134
-135
+  <div *ngIf="(ePeopleSearch | async)?.totalElements == 0 && searchDone"
-136
+       class="alert alert-info w-100 mb-2"
-137
+       role="alert">
-138
+    {{messagePrefix + '.no-items' | translate}}
-139
+  </div>
-140
--
+  <h4>{{messagePrefix + '.headMembers' | translate}}</h4>
--
--
+  <ds-pagination *ngIf="(ePeopleMembersOfGroup | async)?.totalElements > 0"
--
+                 [paginationOptions]="config"
--
+                 [pageInfoState]="(ePeopleMembersOfGroup | async)"
--
+                 [collectionSize]="(ePeopleMembersOfGroup | async)?.totalElements"
--
+                 [hideGear]="true"
--
+                 [hidePagerWhenSinglePage]="true">
--
--
+    <div class="table-responsive">
--
+      <table id="ePeopleMembersOfGroup" class="table table-striped table-hover table-bordered">
--
+        <thead>
--
+        <tr>
--
+          <th scope="col" class="align-middle">{{messagePrefix + '.table.id' | translate}}</th>
--
+          <th scope="col" class="align-middle">{{messagePrefix + '.table.name' | translate}}</th>
--
+          <th scope="col" class="align-middle">{{messagePrefix + '.table.identity' | translate}}</th>
--
+          <th class="align-middle">{{messagePrefix + '.table.edit' | translate}}</th>
--
+        </tr>
--
+        </thead>
--
+        <tbody>
--
+        <tr *ngFor="let eperson of (ePeopleMembersOfGroup | async)?.page">
--
+          <td class="align-middle">{{eperson.id}}</td>
--
+          <td class="align-middle">
--
+            <a (click)="ePersonDataService.startEditingNewEPerson(eperson)"
--
+               [routerLink]="[ePersonDataService.getEPeoplePageRouterLink()]">
--
+              {{ dsoNameService.getName(eperson) }}
--
+            </a>
--
+          </td>
--
+          <td class="align-middle">
--
+            {{messagePrefix + '.table.email' | translate}}: {{ eperson.email ? eperson.email : '-' }}<br/>
--
+            {{messagePrefix + '.table.netid' | translate}}: {{ eperson.netid ? eperson.netid : '-' }}
--
+          </td>
--
+          <td class="align-middle">
--
+            <div class="btn-group edit-field">
--
+              <button (click)="deleteMemberFromGroup(eperson)"
--
+                      [disabled]="actionConfig.remove.disabled"
--
+                      [ngClass]="['btn btn-sm', actionConfig.remove.css]"
--
+                      title="{{messagePrefix + '.table.edit.buttons.remove' | translate: { name: dsoNameService.getName(eperson) } }}">
--
+                <i [ngClass]="actionConfig.remove.icon"></i>
--
+              </button>
--
+            </div>
--
+          </td>
--
+        </tr>
--
+        </tbody>
--
+      </table>
--
+    </div>
--
--
+  </ds-pagination>
--
--
+  <div *ngIf="(ePeopleMembersOfGroup | async) == undefined || (ePeopleMembersOfGroup | async)?.totalElements == 0" class="alert alert-info w-100 mb-2"
--
+       role="alert">
--
+    {{messagePrefix + '.no-members-yet' | translate}}
--
+  </div>
--
-141
+</ng-container>

Frontend

Commits

Jira Issues

Add shortcut