Commits

Nathan Buckingham authored 9435f1c4a73
Add done() to async tests
No tags

src/app/core/auth/browser-auth-request.service.spec.ts

Modified
11 11
12 12 beforeEach(() => {
13 13 href = 'https://rest.api/auth/shortlivedtokens';
14 14 requestService = jasmine.createSpyObj('requestService', {
15 15 'generateRequestId': '8bb0582d-5013-4337-af9c-763beb25aae2'
16 16 });
17 17 service = new BrowserAuthRequestService(null, requestService, null);
18 18 });
19 19
20 20 describe(`createShortLivedTokenRequest`, () => {
21 - it(`should return a PostRequest`, () => {
21 + it(`should return a PostRequest`, (done) => {
22 22 const obs = (service as any).createShortLivedTokenRequest(href) as Observable<PostRequest>;
23 23 obs.subscribe((result: PostRequest) => {
24 24 expect(result.constructor.name).toBe('PostRequest');
25 + done();
25 26 });
26 27 });
27 28
28 - it(`should return a request with the given href`, () => {
29 + it(`should return a request with the given href`, (done) => {
29 30 const obs = (service as any).createShortLivedTokenRequest(href) as Observable<PostRequest>;
30 31 obs.subscribe((result: PostRequest) => {
31 32 expect(result.href).toBe(href);
33 + done();
32 34 });
33 35 });
34 36 });
35 37 });

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut