DigitaleBibliothek / Frontend / a6e093038c9

Commits

Yury Bondarenko authored a6e093038c9 28 Mar 2024

Manual fix: use base components in unit test templates

`Themed*` components should be used in the actual codebase to ensure we retain theme support.
However, in unit tests these components won't work without a fully-functional `ThemeService` & `Store`.

For this reason, the lint plugin allows `ds-base-*` selectors in unit test templates.

src/app/my-dspace-page/collection-selector/collection-selector.component.spec.ts

Modified

-1
+/* eslint-disable max-classes-per-file */
-2
+import {
-3
+  ChangeDetectionStrategy,
-4
+  ChangeDetectorRef,
--
+  Component,
-5
+  ElementRef,
-6
+  NO_ERRORS_SCHEMA,
-7
+} from '@angular/core';
-8
+import {
-9
+  ComponentFixture,
-10
+  TestBed,
-11
+  waitForAsync,
-12
+} from '@angular/core/testing';
-13
+import { ActivatedRoute } from '@angular/router';
-14
+import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
-121
+  beforeEach(waitForAsync(() => {
-122
+    TestBed.configureTestingModule({
-123
+      imports: [
-124
+        TranslateModule.forRoot({
-125
+          loader: {
-126
+            provide: TranslateLoader,
-127
+            useClass: TranslateLoaderMock,
-128
+          },
-129
+        }),
-130
+        CollectionSelectorComponent,
--
+        // CollectionDropdownComponent,
-+
+        CollectionDropdownComponent,
-132
+      ],
-133
+      providers: [
-134
+        { provide: CollectionDataService, useValue: collectionDataServiceMock },
-135
+        { provide: ElementRef, useClass: MockElementRef },
-136
+        { provide: NgbActiveModal, useValue: modal },
-137
+        { provide: ActivatedRoute, useValue: {} },
--
+        { provide: CollectionDropdownComponent, useClass: CollectionDropdownStubComponent },
-138
+        ChangeDetectorRef,
-139
+      ],
-140
+      schemas: [NO_ERRORS_SCHEMA],
-141
+    })
-142
+      .overrideComponent(CollectionSelectorComponent, {
-143
+        set: {
-144
+          changeDetection: ChangeDetectionStrategy.Default,
-145
+        },
-146
+      })
-147
+      .compileComponents();
-148
+  }));
-149
-150
+  beforeEach(() => {
-151
+    scheduler = getTestScheduler();
-152
+    fixture = TestBed.overrideComponent(CollectionSelectorComponent, {
-153
+      set: {
--
+        template: '<ds-collection-dropdown (selectionChange)="selectObject($event)"></ds-collection-dropdown>',
-+
+        template: '<ds-base-collection-dropdown (selectionChange)="selectObject($event)"></ds-base-collection-dropdown>',
-155
+      },
-156
+    }).createComponent(CollectionSelectorComponent);
-157
+    component = fixture.componentInstance;
-158
+    fixture.detectChanges();
-159
+  });
-160
-161
+  it('should create', () => {
-162
+    expect(component).toBeTruthy();
-163
+  });
-164
-171
+    component.selectObject({ collection: { name: 'test', id: 'test', uuid: 'test' }, communities: [] });
-172
-173
+    expect(component.selectObject).toHaveBeenCalled();
-174
+  });
-175
-176
+  it('should close the dialog', () => {
-177
+    component.close();
-178
+    expect((component as any).activeModal.close).toHaveBeenCalled();
-179
+  });
-180
+});
--
--
+@Component({
--
+  selector: 'ds-collection-dropdown',
--
+  template: `
--
+    <li
--
+      (click)="test()"
--
+            class="dropdown-item collection-item"
--
+            title="test" >
--
+    </li>`,
--
+  standalone: true,
--
+})
--
+export class CollectionDropdownStubComponent {
--
+  test() {
--
+    return 'test';
--
+  }
--
+}

Frontend

Commits

Jira Issues

Add shortcut