DigitaleBibliothek / Frontend / b55e4327a88

Commits

Art Lowel authored b55e4327a88 24 Jun 2022

fix issue where curation tasks wouldn't work for collections and communities because the handle was in the wrong format

src/app/curation-form/curation-form.component.spec.ts

Modified

-8
+import { createFailedRemoteDataObject$, createSuccessfulRemoteDataObject$ } from '../shared/remote-data.utils';
-9
+import { NotificationsServiceStub } from '../shared/testing/notifications-service.stub';
-10
+import { RouterStub } from '../shared/testing/router.stub';
-11
+import { NotificationsService } from '../shared/notifications/notifications.service';
-12
+import { Router } from '@angular/router';
-13
+import { FormsModule, ReactiveFormsModule } from '@angular/forms';
-14
+import { By } from '@angular/platform-browser';
-15
+import { ConfigurationDataService } from '../core/data/configuration-data.service';
-16
+import { ConfigurationProperty } from '../core/shared/configuration-property.model';
-17
+import { getProcessDetailRoute } from '../process-page/process-page-routing.paths';
-+
+import { HandleService } from '../shared/handle.service';
-19
-20
+describe('CurationFormComponent', () => {
-21
+  let comp: CurationFormComponent;
-22
+  let fixture: ComponentFixture<CurationFormComponent>;
-23
-24
+  let scriptDataService: ScriptDataService;
-25
+  let processDataService: ProcessDataService;
-26
+  let configurationDataService: ConfigurationDataService;
-+
+  let handleService: HandleService;
-28
+  let notificationsService;
-29
+  let router;
-30
-31
+  const process = Object.assign(new Process(), {processId: 'process-id'});
-32
-33
+  beforeEach(waitForAsync(() => {
-34
-35
+    scriptDataService = jasmine.createSpyObj('scriptDataService', {
-36
+      invoke: createSuccessfulRemoteDataObject$(process)
-37
+    });
-46
+        values: [
-47
+          'org.dspace.ctask.general.ProfileFormats = profileformats',
-48
+          '',
-49
+          'org.dspace.ctask.general.RequiredMetadata = requiredmetadata',
-50
+          'org.dspace.ctask.general.MetadataValueLinkChecker = checklinks',
-51
+          'value-to-be-skipped'
-52
+        ]
-53
+      }))
-54
+    });
-55
-+
+    handleService = {
-+
+      normalizeHandle: (a) => a
-+
+    } as any;
-+
-60
+    notificationsService = new NotificationsServiceStub();
-61
+    router = new RouterStub();
-62
-63
+    TestBed.configureTestingModule({
-64
+      imports: [TranslateModule.forRoot(), FormsModule, ReactiveFormsModule],
-65
+      declarations: [CurationFormComponent],
-66
+      providers: [
--
+        {provide: ScriptDataService, useValue: scriptDataService},
--
+        {provide: ProcessDataService, useValue: processDataService},
--
+        {provide: NotificationsService, useValue: notificationsService},
--
+        {provide: Router, useValue: router},
--
+        {provide: ConfigurationDataService, useValue: configurationDataService},
-+
+        { provide: ScriptDataService, useValue: scriptDataService },
-+
+        { provide: ProcessDataService, useValue: processDataService },
-+
+        { provide: NotificationsService, useValue: notificationsService },
-+
+        { provide: HandleService, useValue: handleService },
-+
+        { provide: Router, useValue: router},
-+
+        { provide: ConfigurationDataService, useValue: configurationDataService },
-73
+      ],
-74
+      schemas: [CUSTOM_ELEMENTS_SCHEMA]
-75
+    }).compileComponents();
-76
+  }));
-77
-78
+  beforeEach(() => {
-79
+    fixture = TestBed.createComponent(CurationFormComponent);
-80
+    comp = fixture.componentInstance;
-81
-82
+    fixture.detectChanges();
-143
+  });
-144
+  it('should use "all" when the handle provided by the form is empty and when no dsoHandle is provided', () => {
-145
-146
+    comp.submit();
-147
-148
+    expect(scriptDataService.invoke).toHaveBeenCalledWith('curate', [
-149
+      {name: '-t', value: 'profileformats'},
-150
+      {name: '-i', value: 'all'},
-151
+    ], []);
-152
+  });
-+
-+
+  it(`should show an error notification and return when an invalid dsoHandle is provided`, () => {
-+
+    comp.dsoHandle = 'test-handle';
-+
+    spyOn(handleService, 'normalizeHandle').and.returnValue(null);
-+
+    comp.submit();
-+
-+
+    expect(notificationsService.error).toHaveBeenCalled();
-+
+    expect(scriptDataService.invoke).not.toHaveBeenCalled();
-+
+  });
-162
+});

Frontend

Commits

Jira Issues

Add shortcut