DigitaleBibliothek / Frontend / b8c26a71c33

Commits

Giuseppe Digilio authored b8c26a71c33 02 Apr 2024

[DURACOM-234] Fixes after migrating to functional guards

src/app/item-page/edit-item-page/edit-item-page.component.spec.ts

Modified

--
+/* eslint-disable max-classes-per-file */
-1
+import {
-2
+  ChangeDetectionStrategy,
-3
+  NO_ERRORS_SCHEMA,
-4
+} from '@angular/core';
-5
+import {
-6
+  ComponentFixture,
-7
+  fakeAsync,
-8
+  TestBed,
-9
+  waitForAsync,
-10
+} from '@angular/core/testing';
-11
+import { By } from '@angular/platform-browser';
-12
+import {
-13
+  ActivatedRoute,
-14
+  ActivatedRouteSnapshot,
-+
+  CanActivateFn,
-16
+  RouterModule,
-17
+  RouterStateSnapshot,
--
+  UrlTree,
-18
+} from '@angular/router';
-19
+import {
-20
+  TranslateLoader,
-21
+  TranslateModule,
-22
+} from '@ngx-translate/core';
-23
+import {
-24
+  Observable,
-25
+  of as observableOf,
-26
+} from 'rxjs';
-27
-28
+import { Item } from '../../core/shared/item.model';
-29
+import { TranslateLoaderMock } from '../../shared/mocks/translate-loader.mock';
-30
+import { createSuccessfulRemoteDataObject } from '../../shared/remote-data.utils';
-31
+import { EditItemPageComponent } from './edit-item-page.component';
-32
--
+describe('ItemPageComponent', () => {
-+
+describe('EditItemPageComponent', () => {
-34
+  let comp: EditItemPageComponent;
-35
+  let fixture: ComponentFixture<EditItemPageComponent>;
-36
--
+  class AcceptAllGuard  {
--
+    canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<boolean | UrlTree> | Promise<boolean | UrlTree> | boolean | UrlTree {
--
+      return observableOf(true);
--
+    }
--
+  }
-+
+  const AcceptAllGuard: CanActivateFn = (
-+
+    route: ActivatedRouteSnapshot,
-+
+    state: RouterStateSnapshot,
-+
+  ): Observable<boolean> => {
-+
+    return observableOf(true);
-+
+  };
-43
--
+  class AcceptNoneGuard  {
--
+    canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<boolean | UrlTree> | Promise<boolean | UrlTree> | boolean | UrlTree {
--
+      return observableOf(false);
--
+    }
--
+  }
-+
+  const AcceptNoneGuard: CanActivateFn = (
-+
+    route: ActivatedRouteSnapshot,
-+
+    state: RouterStateSnapshot,
-+
+  ): Observable<boolean> => {
-+
+    return observableOf(false);
-+
+  };
-50
--
+  const accesiblePages = ['accessible'];
--
+  const inaccesiblePages = ['inaccessible', 'inaccessibleDoubleGuard'];
-+
+  const accessiblePages = ['accessible'];
-+
+  const inaccessiblePages = ['inaccessible', 'inaccessibleDoubleGuard'];
-53
+  const mockRoute = {
-54
+    snapshot: {
-55
+      firstChild: {
-56
+        routeConfig: {
--
+          path: accesiblePages[0],
-+
+          path: accessiblePages[0],
-58
+        },
-59
+      },
-60
+      routerState: {
-61
+        snapshot: undefined,
-62
+      },
-63
+    },
-64
+    routeConfig: {
-65
+      children: [
-66
+        {
--
+          path: accesiblePages[0],
-+
+          path: accessiblePages[0],
-68
+          canActivate: [AcceptAllGuard],
-69
+        }, {
--
+          path: inaccesiblePages[0],
-+
+          path: inaccessiblePages[0],
-71
+          canActivate: [AcceptNoneGuard],
-72
+        }, {
--
+          path: inaccesiblePages[1],
-+
+          path: inaccessiblePages[1],
-74
+          canActivate: [AcceptAllGuard, AcceptNoneGuard],
-75
+        },
-76
+      ],
-77
+    },
-78
+    data: observableOf({ dso: createSuccessfulRemoteDataObject(new Item()) }),
-79
+  };
-80
--
+  const mockRouter = {
--
+    routerState: {
--
+      snapshot: undefined,
--
+    },
--
+    events: observableOf(undefined),
--
+  };
--
-81
+  beforeEach(waitForAsync(() => {
-82
+    TestBed.configureTestingModule({
-83
+      imports: [
-84
+        RouterModule.forRoot([]),
-85
+        TranslateModule.forRoot({
-86
+          loader: {
-87
+            provide: TranslateLoader,
-88
+            useClass: TranslateLoaderMock,
-89
+          },
-90
+        }),
-91
+        EditItemPageComponent,
-92
+      ],
-93
+      providers: [
-94
+        { provide: ActivatedRoute, useValue: mockRoute },
--
+        AcceptAllGuard,
--
+        AcceptNoneGuard,
-95
+      ],
-96
+      schemas: [NO_ERRORS_SCHEMA],
-97
+    }).overrideComponent(EditItemPageComponent, {
-98
+      set: { changeDetection: ChangeDetectionStrategy.Default },
-99
+    }).compileComponents();
-100
+  }));
-101
-102
+  beforeEach(waitForAsync(() => {
-103
+    fixture = TestBed.createComponent(EditItemPageComponent);
-104
+    comp = fixture.componentInstance;
--
+    spyOn((comp as any).injector, 'get').and.callFake((a) => new a());
-+
+    // spyOn((comp as any).injector, 'get').and.callFake((a) => new a());
-106
+    fixture.detectChanges();
-107
+  }));
-108
-109
+  describe('ngOnInit', () => {
-110
+    it('should enable tabs that the user can activate', fakeAsync(() => {
-111
+      const enabledItems = fixture.debugElement.queryAll(By.css('a.nav-link'));
--
+      expect(enabledItems.length).toBe(accesiblePages.length);
-+
+      expect(enabledItems.length).toBe(accessiblePages.length);
-113
+    }));
-114
-115
+    it('should disable tabs that the user can not activate', () => {
-116
+      const disabledItems = fixture.debugElement.queryAll(By.css('button.nav-link.disabled'));
--
+      expect(disabledItems.length).toBe(inaccesiblePages.length);
-+
+      expect(disabledItems.length).toBe(inaccessiblePages.length);
-118
+    });
-119
+  });
-120
+});

Frontend

Commits

Jira Issues

Add shortcut