DigitaleBibliothek / Frontend / c40f31279f8

Commits

Corrado Lombardi authored c40f31279f8 17 Nov 2020

[CSTPER-66] moved refreshCache function to common ComColDataService, tests have been moved accordingly.

Used HalEndpointService to discover communities search top endpoint

src/app/core/data/comcol-data.service.spec.ts

Modified

-10
+import { CoreState } from '../core.reducers';
-11
+import { Community } from '../shared/community.model';
-12
+import { HALEndpointService } from '../shared/hal-endpoint.service';
-13
+import { Item } from '../shared/item.model';
-14
+import { ComColDataService } from './comcol-data.service';
-15
+import { CommunityDataService } from './community-data.service';
-16
+import { DSOChangeAnalyzer } from './dso-change-analyzer.service';
-17
+import { FindByIDRequest, FindListOptions } from './request.models';
-18
+import { RequestEntry } from './request.reducer';
-19
+import { RequestService } from './request.service';
-+
+import {createNoContentRemoteDataObject$, createSuccessfulRemoteDataObject$} from '../../shared/remote-data.utils';
-21
-22
+const LINK_NAME = 'test';
-23
-24
+class TestService extends ComColDataService<any> {
-25
-26
+  constructor(
-27
+    protected requestService: RequestService,
-28
+    protected rdbService: RemoteDataBuildService,
-29
+    protected store: Store<CoreState>,
-30
+    protected cds: CommunityDataService,
-45
+}
-46
-47
+describe('ComColDataService', () => {
-48
+  let scheduler: TestScheduler;
-49
+  let service: TestService;
-50
+  let requestService: RequestService;
-51
+  let cds: CommunityDataService;
-52
+  let objectCache: ObjectCacheService;
-53
+  let halService: any = {};
-54
--
+  const rdbService = {} as RemoteDataBuildService;
-+
+  const rdbService = {
-+
+    buildSingle : () => null
-+
+  } as any;
-58
+  const store = {} as Store<CoreState>;
-59
+  const notificationsService = {} as NotificationsService;
-60
+  const http = {} as HttpClient;
-61
+  const comparator = {} as any;
-62
-63
+  const scopeID = 'd9d30c0c-69b7-4369-8397-ca67c888974d';
-64
+  const options = Object.assign(new FindListOptions(), {
-65
+    scopeID: scopeID
-66
+  });
-67
+  const getRequestEntry$ = (successful: boolean) => {
-174
+      });
-175
-176
+      it('should throw an error', () => {
-177
+        const result = service.getBrowseEndpoint(options);
-178
+        const expected = cold('--#-', undefined, new Error(`The Community with scope ${scopeID} couldn't be retrieved`));
-179
-180
+        expect(result).toBeObservable(expected);
-181
+      });
-182
+    });
-183
-+
+    describe('cache refresh', () => {
-+
+      let communityWithoutParentHref;
-+
+      let data;
-+
-+
+      beforeEach(() => {
-+
+        scheduler = getTestScheduler();
-+
+        halService = {
-+
+          getEndpoint: (linkPath) => 'https://rest.api/core/' + linkPath
-+
+        };
-+
+        service = initTestService();
-+
-+
+      })
-+
+      describe('cache refreshed top level community', () => {
-+
+        beforeEach(() => {
-+
+          spyOn(rdbService, 'buildSingle').and.returnValue(createNoContentRemoteDataObject$());
-+
+          data = {
-+
+            dso: Object.assign(new Community(), {
-+
+              metadata: [{
-+
+                key: 'dc.title',
-+
+                value: 'top level community'
-+
+              }]
-+
+            }),
-+
+            _links: {
-+
+              parentCommunity: {
-+
+                href: 'topLevel/parentCommunity'
-+
+              }
-+
+            }
-+
+          };
-+
+          communityWithoutParentHref = {
-+
+            dso: Object.assign(new Community(), {
-+
+              metadata: [{
-+
+                key: 'dc.title',
-+
+                value: 'top level community'
-+
+              }]
-+
+            }),
-+
+            _links: {}
-+
+          };
-+
+        });
-+
+        it('top level community cache refreshed', () => {
-+
+          scheduler.schedule(() => (service as any).refreshCache(data));
-+
+          scheduler.flush();
-+
+          expect(requestService.removeByHrefSubstring).toHaveBeenCalledWith('https://rest.api/core/communities/search/top');
-+
+        });
-+
+        it('top level community without parent link, cache not refreshed', () => {
-+
+          scheduler.schedule(() => (service as any).refreshCache(communityWithoutParentHref));
-+
+          scheduler.flush();
-+
+          expect(requestService.removeByHrefSubstring).not.toHaveBeenCalled();
-+
+        });
-+
+      });
-+
-+
+      describe('cache refreshed child community', () => {
-+
+        beforeEach(() => {
-+
+          const parentCommunity = Object.assign(new Community(), {
-+
+            uuid: 'a20da287-e174-466a-9926-f66as300d399',
-+
+            id: 'a20da287-e174-466a-9926-f66as300d399',
-+
+            metadata: [{
-+
+              key: 'dc.title',
-+
+              value: 'parent community'
-+
+            }],
-+
+            _links: {}
-+
+          });
-+
+          spyOn(rdbService, 'buildSingle').and.returnValue(createSuccessfulRemoteDataObject$(parentCommunity));
-+
+          data = {
-+
+            dso: Object.assign(new Community(), {
-+
+              metadata: [{
-+
+                key: 'dc.title',
-+
+                value: 'child community'
-+
+              }]
-+
+            }),
-+
+            _links: {
-+
+              parentCommunity: {
-+
+                href: 'child/parentCommunity'
-+
+              }
-+
+            }
-+
+          };
-+
+        });
-+
+        it('child level community cache refreshed', () => {
-+
+          scheduler.schedule(() => (service as any).refreshCache(data));
-+
+          scheduler.flush();
-+
+          expect(requestService.removeByHrefSubstring).toHaveBeenCalledWith('a20da287-e174-466a-9926-f66as300d399');
-+
+        });
-+
+      });
-+
+    });
-+
-268
+  });
-269
-270
+});

Frontend

Commits

Jira Issues

Add shortcut