Commits

Alexandre Vryghem authored c687d3ff5d1
115046: Fixed performance issues in virtual metadata popup
No tags

src/app/item-page/edit-item-page/virtual-metadata/virtual-metadata.component.html

Modified
1 1 <div [ngClass]="showThumbnails ? 'hide-modal-thumbnail-column' : ''">
2 2 <div class="modal-header">{{'virtual-metadata.delete-relationship.modal-head' | translate}}
3 3 <button type="button" class="close" (click)="close.emit()" aria-label="Close">
4 4 <span aria-hidden="true">×</span>
5 5 </button>
6 6 </div>
7 7 <div class="modal-body">
8 - <ng-container *ngFor="let item of items; trackBy: trackItem">
9 - <div *ngVar="(isSelectedVirtualMetadataItem(item) | async) as selected"
10 - (click)="setSelectedVirtualMetadataItem(item, !selected)"
8 + <ng-container *ngFor="let itemDTO of itemDTOs$ | async; trackBy: trackItemDTO">
9 + <div *ngVar="(itemDTO.isSelectedVirtualMetadataItem$ | async) as selected"
10 + (click)="setSelectedVirtualMetadataItem(itemDTO.item, !selected)"
11 11 class="item d-flex flex-row">
12 12 <div class="m-2">
13 13 <label>
14 14 <input class="select" type="checkbox" [checked]="selected">
15 15 </label>
16 16 </div>
17 17 <div class="flex-column">
18 - <ds-listable-object-component-loader [object]="item">
18 + <ds-listable-object-component-loader [object]="itemDTO.item">
19 19 </ds-listable-object-component-loader>
20 - <div *ngFor="let metadata of virtualMetadata.get(item.uuid)">
20 + <div *ngFor="let metadata of virtualMetadata.get(itemDTO.item.uuid)">
21 21 <div class="font-weight-bold">
22 22 {{metadata.metadataField}}
23 23 </div>
24 24 <div>
25 25 {{metadata.metadataValue.value}}
26 26 </div>
27 27 </div>
28 28 </div>
29 29 </div>
30 30 </ng-container>
31 31 <div class="d-flex flex-row-reverse m-2">
32 32 <button class="btn btn-primary save"
33 33 (click)="save.emit()">
34 - <i class="fas fa-save"></i> {{"item.edit.metadata.save-button" | translate}}
34 + <i aria-hidden="true" class="fas fa-save"></i> {{ 'item.edit.metadata.save-button' | translate }}
35 35 </button>
36 36 </div>
37 37 </div>
38 38 </div>

Everything looks good. We'll let you know here if there's anything you should know about.

Add shortcut