DigitaleBibliothek / Frontend / ce096496eb6

Commits

Tim Donohue authored and GitHub committed ce096496eb6 Merge 31 Jan 2023

Merge pull request #2065 from atmire/single-page-of-bitstreams-for-citation-pdf-url-tag

Only check 1 page of bitstreams when generating the citation_pdf_url tag

src/app/core/metadata/metadata.service.spec.ts

Modified

-1
+import { fakeAsync, tick } from '@angular/core/testing';
-2
+import { Meta, Title } from '@angular/platform-browser';
-3
+import { NavigationEnd, Router } from '@angular/router';
-4
-5
+import { TranslateService } from '@ngx-translate/core';
-6
+import { Observable, of as observableOf, of } from 'rxjs';
-7
-8
+import { RemoteData } from '../data/remote-data';
-9
+import { Item } from '../shared/item.model';
-10
--
+import { ItemMock, MockBitstream1, MockBitstream3 } from '../../shared/mocks/item.mock';
-+
+import {
-+
+  ItemMock,
-+
+  MockBitstream1,
-+
+  MockBitstream3,
-+
+  MockBitstream2
-+
+} from '../../shared/mocks/item.mock';
-17
+import { createSuccessfulRemoteDataObject, createSuccessfulRemoteDataObject$ } from '../../shared/remote-data.utils';
-18
+import { PaginatedList } from '../data/paginated-list.model';
-19
+import { Bitstream } from '../shared/bitstream.model';
-20
+import { MetadataValue } from '../shared/metadata.models';
-21
-22
+import { MetadataService } from './metadata.service';
-23
+import { RootDataService } from '../data/root-data.service';
-24
+import { Bundle } from '../shared/bundle.model';
-25
+import { createPaginatedList } from '../../shared/testing/utils.test';
-26
+import { getMockTranslateService } from '../../shared/mocks/translate.service.mock';
-27
+import { DSONameService } from '../breadcrumbs/dso-name.service';
-28
+import { HardRedirectService } from '../services/hard-redirect.service';
-29
+import { getMockStore } from '@ngrx/store/testing';
-30
+import { AddMetaTagAction, ClearMetaTagAction } from './meta-tag.actions';
-31
+import { AuthorizationDataService } from '../data/feature-authorization/authorization-data.service';
-+
+import { AppConfig } from '../../../config/app-config.interface';
-33
-34
+describe('MetadataService', () => {
-35
+  let metadataService: MetadataService;
-36
-37
+  let meta: Meta;
-38
-39
+  let title: Title;
-40
-41
+  let dsoNameService: DSONameService;
-42
-43
+  let bundleDataService;
-44
+  let bitstreamDataService;
-45
+  let rootService: RootDataService;
-46
+  let translateService: TranslateService;
-47
+  let hardRedirectService: HardRedirectService;
-48
+  let authorizationService: AuthorizationDataService;
-49
-50
+  let router: Router;
-51
+  let store;
-52
-+
+  let appConfig: AppConfig;
-+
-55
+  const initialState = { 'core': { metaTag: { tagsInUse: ['title', 'description'] }}};
-56
-57
-58
+  beforeEach(() => {
-59
+    rootService = jasmine.createSpyObj({
-60
+      findRoot: createSuccessfulRemoteDataObject$({ dspaceVersion: 'mock-dspace-version' })
-61
+    });
-62
+    bitstreamDataService = jasmine.createSpyObj({
-63
+      findListByHref: createSuccessfulRemoteDataObject$(createPaginatedList([MockBitstream3])),
-64
+    });
-87
+      getCurrentOrigin: 'https://request.org',
-88
+    });
-89
+    authorizationService = jasmine.createSpyObj('authorizationService', {
-90
+      isAuthorized: observableOf(true)
-91
+    });
-92
-93
+    // @ts-ignore
-94
+    store = getMockStore({ initialState });
-95
+    spyOn(store, 'dispatch');
-96
-+
+    appConfig = {
-+
+      item: {
-+
+        bitstream: {
-+
+          pageSize: 5
-+
+        }
-+
+      }
-+
+    } as any;
-+
-105
+    metadataService = new MetadataService(
-106
+      router,
-107
+      translateService,
-108
+      meta,
-109
+      title,
-110
+      dsoNameService,
-111
+      bundleDataService,
-112
+      bitstreamDataService,
-113
+      undefined,
-114
+      rootService,
-115
+      store,
-116
+      hardRedirectService,
-+
+      appConfig,
-118
+      authorizationService
-119
+    );
-120
+  });
-121
-122
+  it('items page should set meta tags', fakeAsync(() => {
-123
+    (metadataService as any).processRouteChange({
-124
+      data: {
-125
+        value: {
-126
+          dso: createSuccessfulRemoteDataObject(ItemMock),
-127
+        }
-368
+            }
-369
+          }
-370
+        });
-371
+        tick();
-372
+        expect(meta.addTag).toHaveBeenCalledWith({
-373
+          name: 'citation_pdf_url',
-374
+          content: 'https://request.org/bitstreams/4db100c1-e1f5-4055-9404-9bc3e2d15f29/download'
-375
+        });
-376
+      }));
-377
--
+      it('should link to first Bitstream with allowed format', fakeAsync(() => {
--
+        const bitstreams = [MockBitstream3, MockBitstream3, MockBitstream1];
--
+        (bundleDataService.findByItemAndName as jasmine.Spy).and.returnValue(mockBundleRD$(bitstreams));
--
+        (bitstreamDataService.findListByHref as jasmine.Spy).and.returnValues(
--
+          ...mockBitstreamPages$(bitstreams).map(bp => createSuccessfulRemoteDataObject$(bp)),
--
+        );
-+
+      describe(`when there's a bitstream with an allowed format on the first page`, () => {
-+
+        let bitstreams;
-380
--
+        (metadataService as any).processRouteChange({
--
+          data: {
--
+            value: {
--
+              dso: createSuccessfulRemoteDataObject(ItemMock),
--
+            }
--
+          }
-+
+        beforeEach(() => {
-+
+          bitstreams = [MockBitstream2, MockBitstream3, MockBitstream1];
-+
+          (bundleDataService.findByItemAndName as jasmine.Spy).and.returnValue(mockBundleRD$(bitstreams));
-+
+          (bitstreamDataService.findListByHref as jasmine.Spy).and.returnValues(
-+
+            ...mockBitstreamPages$(bitstreams).map(bp => createSuccessfulRemoteDataObject$(bp)),
-+
+          );
-387
+        });
--
+        tick();
--
+        expect(meta.addTag).toHaveBeenCalledWith({
--
+          name: 'citation_pdf_url',
--
+          content: 'https://request.org/bitstreams/cf9b0c8e-a1eb-4b65-afd0-567366448713/download'
--
+        });
--
+      }));
-+
-+
+        it('should link to first Bitstream with allowed format', fakeAsync(() => {
-+
+          (metadataService as any).processRouteChange({
-+
+            data: {
-+
+              value: {
-+
+                dso: createSuccessfulRemoteDataObject(ItemMock),
-+
+              }
-+
+            }
-+
+          });
-+
+          tick();
-+
+          expect(meta.addTag).toHaveBeenCalledWith({
-+
+            name: 'citation_pdf_url',
-+
+            content: 'https://request.org/bitstreams/99b00f3c-1cc6-4689-8158-91965bee6b28/download'
-+
+          });
-+
+        }));
-+
-+
+      });
-+
-406
+    });
-407
+  });
-408
-+
+  describe(`when there's no bitstream with an allowed format on the first page`, () => {
-+
+    let bitstreams;
-+
-+
+    beforeEach(() => {
-+
+      bitstreams = [MockBitstream1, MockBitstream3, MockBitstream2];
-+
+      (bundleDataService.findByItemAndName as jasmine.Spy).and.returnValue(mockBundleRD$(bitstreams));
-+
+      (bitstreamDataService.findListByHref as jasmine.Spy).and.returnValues(
-+
+        ...mockBitstreamPages$(bitstreams).map(bp => createSuccessfulRemoteDataObject$(bp)),
-+
+      );
-+
+    });
-+
-+
+    it(`shouldn't add a citation_pdf_url meta tag`, fakeAsync(() => {
-+
+      (metadataService as any).processRouteChange({
-+
+        data: {
-+
+          value: {
-+
+            dso: createSuccessfulRemoteDataObject(ItemMock),
-+
+          }
-+
+        }
-+
+      });
-+
+      tick();
-+
+      expect(meta.addTag).not.toHaveBeenCalledWith({
-+
+        name: 'citation_pdf_url',
-+
+        content: 'https://request.org/bitstreams/99b00f3c-1cc6-4689-8158-91965bee6b28/download'
-+
+      });
-+
+    }));
-+
-+
+  });
-+
-+
-438
+  describe('tagstore', () => {
-439
+    beforeEach(fakeAsync(() => {
-440
+      (metadataService as any).processRouteChange({
-441
+        data: {
-442
+          value: {
-443
+            dso: createSuccessfulRemoteDataObject(ItemMock),
-444
+          }
-445
+        }
-446
+      });
-447
+      tick();

Frontend

Commits

Jira Issues

Add shortcut