DigitaleBibliothek / Frontend / fb66b5abd6b

Commits

Alexandre Vryghem authored fb66b5abd6b 26 May 2023

102039: Use patch to delete multiple bitstreams at once

src/app/core/data/bitstream-data.service.spec.ts

Modified

-+
+import { TestBed } from '@angular/core/testing';
-2
+import { BitstreamDataService } from './bitstream-data.service';
-3
+import { ObjectCacheService } from '../cache/object-cache.service';
-4
+import { RequestService } from './request.service';
-5
+import { Bitstream } from '../shared/bitstream.model';
-6
+import { HALEndpointService } from '../shared/hal-endpoint.service';
-7
+import { BitstreamFormatDataService } from './bitstream-format-data.service';
--
+import { of as observableOf } from 'rxjs';
-+
+import { Observable, of as observableOf } from 'rxjs';
-9
+import { BitstreamFormat } from '../shared/bitstream-format.model';
-10
+import { BitstreamFormatSupportLevel } from '../shared/bitstream-format-support-level';
--
+import { PutRequest } from './request.models';
-+
+import { PatchRequest, PutRequest } from './request.models';
-12
+import { getMockRequestService } from '../../shared/mocks/request.service.mock';
-13
+import { HALEndpointServiceStub } from '../../shared/testing/hal-endpoint-service.stub';
-14
+import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
-15
+import { getMockRemoteDataBuildService } from '../../shared/mocks/remote-data-build.service.mock';
-16
+import { testSearchDataImplementation } from './base/search-data.spec';
-17
+import { testPatchDataImplementation } from './base/patch-data.spec';
-18
+import { testDeleteDataImplementation } from './base/delete-data.spec';
-+
+import { DSOChangeAnalyzer } from './dso-change-analyzer.service';
-+
+import { NotificationsService } from '../../shared/notifications/notifications.service';
-+
+import objectContaining = jasmine.objectContaining;
-+
+import { RemoteData } from './remote-data';
-+
+import { FollowLinkConfig } from '../../shared/utils/follow-link-config.model';
-24
-25
+describe('BitstreamDataService', () => {
-26
+  let service: BitstreamDataService;
-27
+  let objectCache: ObjectCacheService;
-28
+  let requestService: RequestService;
-29
+  let halService: HALEndpointService;
-30
+  let bitstreamFormatService: BitstreamFormatDataService;
-31
+  let rdbService: RemoteDataBuildService;
-32
+  const bitstreamFormatHref = 'rest-api/bitstreamformats';
-33
--
+  const bitstream = Object.assign(new Bitstream(), {
--
+    uuid: 'fake-bitstream',
-+
+  const bitstream1 = Object.assign(new Bitstream(), {
-+
+    id: 'fake-bitstream1',
-+
+    uuid: 'fake-bitstream1',
-37
+    _links: {
--
+      self: { href: 'fake-bitstream-self' }
-+
+      self: { href: 'fake-bitstream1-self' }
-+
+    }
-+
+  });
-+
+  const bitstream2 = Object.assign(new Bitstream(), {
-+
+    id: 'fake-bitstream2',
-+
+    uuid: 'fake-bitstream2',
-+
+    _links: {
-+
+      self: { href: 'fake-bitstream2-self' }
-46
+    }
-47
+  });
-48
+  const format = Object.assign(new BitstreamFormat(), {
-49
+    id: '2',
-50
+    shortDescription: 'PNG',
-51
+    description: 'Portable Network Graphics',
-52
+    supportLevel: BitstreamFormatSupportLevel.Known
-53
+  });
-54
+  const url = 'fake-bitstream-url';
-55
-56
+  beforeEach(() => {
-57
+    objectCache = jasmine.createSpyObj('objectCache', {
-58
+      remove: jasmine.createSpy('remove')
-59
+    });
-60
+    requestService = getMockRequestService();
-61
+    halService = Object.assign(new HALEndpointServiceStub(url));
-62
+    bitstreamFormatService = jasmine.createSpyObj('bistreamFormatService', {
-63
+      getBrowseEndpoint: observableOf(bitstreamFormatHref)
-64
+    });
-65
+    rdbService = getMockRemoteDataBuildService();
-66
--
+    service = new BitstreamDataService(requestService, rdbService, objectCache, halService, null, bitstreamFormatService, null, null);
-+
+    TestBed.configureTestingModule({
-+
+      providers: [
-+
+        { provide: ObjectCacheService, useValue: objectCache },
-+
+        { provide: RequestService, useValue: requestService },
-+
+        { provide: HALEndpointService, useValue: halService },
-+
+        { provide: BitstreamFormatDataService, useValue: bitstreamFormatService },
-+
+        { provide: RemoteDataBuildService, useValue: rdbService },
-+
+        { provide: DSOChangeAnalyzer, useValue: {} },
-+
+        { provide: NotificationsService, useValue: {} },
-+
+      ],
-+
+    });
-+
+    service = TestBed.inject(BitstreamDataService);
-79
+  });
-80
-81
+  describe('composition', () => {
-82
+    const initService = () => new BitstreamDataService(null, null, null, null, null, null, null, null);
-83
+    testSearchDataImplementation(initService);
-84
+    testPatchDataImplementation(initService);
-85
+    testDeleteDataImplementation(initService);
-86
+  });
-87
-88
+  describe('when updating the bitstream\'s format', () => {
-89
+    beforeEach(() => {
--
+      service.updateFormat(bitstream, format);
-+
+      service.updateFormat(bitstream1, format);
-91
+    });
-92
-93
+    it('should send a put request', () => {
-94
+      expect(requestService.send).toHaveBeenCalledWith(jasmine.any(PutRequest));
-95
+    });
-96
+  });
-+
-+
+  describe('removeMultiple', () => {
-+
+    function mockBuildFromRequestUUIDAndAwait(requestUUID$: string | Observable<string>, callback: (rd?: RemoteData<any>) => Observable<unknown>, ..._linksToFollow: FollowLinkConfig<any>[]): Observable<RemoteData<any>> {
-+
+      callback();
-+
+      return;
-+
+    }
-+
-+
+    beforeEach(() => {
-+
+      spyOn(service, 'invalidateByHref');
-+
+      spyOn(rdbService, 'buildFromRequestUUIDAndAwait').and.callFake((requestUUID$: string | Observable<string>, callback: (rd?: RemoteData<any>) => Observable<unknown>, ...linksToFollow: FollowLinkConfig<any>[]) => mockBuildFromRequestUUIDAndAwait(requestUUID$, callback, ...linksToFollow));
-+
+    });
-+
-+
+    it('should be able to 1 bitstream', () => {
-+
+      service.removeMultiple([bitstream1]);
-+
-+
+      expect(requestService.send).toHaveBeenCalledWith(objectContaining({
-+
+        href: `${url}/bitstreams`,
-+
+        body: [
-+
+          { op: 'remove', path: '/bitstreams/fake-bitstream1' },
-+
+        ],
-+
+      } as PatchRequest));
-+
+      expect(service.invalidateByHref).toHaveBeenCalledWith('fake-bitstream1-self');
-+
+    });
-+
-+
+    it('should be able to delete multiple bitstreams', () => {
-+
+      service.removeMultiple([bitstream1, bitstream2]);
-+
-+
+      expect(requestService.send).toHaveBeenCalledWith(objectContaining({
-+
+        href: `${url}/bitstreams`,
-+
+        body: [
-+
+          { op: 'remove', path: '/bitstreams/fake-bitstream1' },
-+
+          { op: 'remove', path: '/bitstreams/fake-bitstream2' },
-+
+        ],
-+
+      } as PatchRequest));
-+
+      expect(service.invalidateByHref).toHaveBeenCalledWith('fake-bitstream1-self');
-+
+      expect(service.invalidateByHref).toHaveBeenCalledWith('fake-bitstream2-self');
-+
+    });
-+
+  });
-135
+});

Frontend

Commits

Jira Issues

Add shortcut